RN: Enable useInsertionEffectsForAnimations
#47595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Enables the `useInsertionEffectsForAnimations` feature flag by default. This changes `useAnimatedProps` to enqueue updates to the `AnimatedNode` graph in `useInsertionEffect` instead of `useLayoutEffect`. The main motivation for `useInsertionEffect` is to avoid unmounting `AnimatedNode` graphs when an `Activity` subtree becomes hidden. Both `useInsertionEffect` and `useLayoutEffect` occur during the commit phase. Although they occur at different moments in the commit phase, the different is difficult to observe and unlikely to impact product code. One observable impact is that with `useInsertionEffect`, animations can now be started from layout effects. Changelog: [General][Changed] - The `AnimatedNode` graph will not occur during the insertion effect phase, which means animations can now be reliably started during layout effects. Differential Revision: D65906157
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65906157 |
|
This pull request has been merged in 316170c. |
|
This pull request was successfully merged by @yungsters in 316170c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables the
useInsertionEffectsForAnimationsfeature flag by default. This changesuseAnimatedPropsto enqueue updates to theAnimatedNodegraph inuseInsertionEffectinstead ofuseLayoutEffect.The main motivation for
useInsertionEffectis to avoid unmountingAnimatedNodegraphs when anActivitysubtree becomes hidden.Both
useInsertionEffectanduseLayoutEffectoccur during the commit phase. Although they occur at different moments in the commit phase, the different is difficult to observe and unlikely to impact product code.One observable impact is that with
useInsertionEffect, animations can now be started from layout effects.Changelog:
[General][Changed] - The
AnimatedNodegraph will not occur during the insertion effect phase, which means animations can now be reliably started during layout effects.Differential Revision: D65906157